Android App Bundle Support Added

[mirsamantajbakhsh]

Dear Claudiu,
First of all I wanted to thank you for creating Obfuscapk. I saw some issues in your repository about working with Android Bundle, beside APK files. Therefore, I've added AAB support to obfuscapk using other repository named BundleDecompiler. I have tested and the results were OK.

Please help me if there are other works I should have done.

Best Regards,
Dr. Tajbakhsh

[mirsamantajbakhsh]

Checks are failing since in the test environment, there is no BundleDecompiler.jar in /usr/bin/BundleDecompiler.jar. I do not know how to fix tests.

[ClaudiuGeorgiu]

Hi @mirsamantajbakhsh, this looks very interesting! Bundle support has been a long desired feature and now you implemented it, so thank you! Here are my thoughts:

1. BundleDecompiler doesn't support windows, I would prefer a cross platform solution but that's ok, however, we have to add some code to show some sort of warning if the user tries to use Obfuscapk on a bundle file on windows;
2. the code for BundleDecompiler is not available and it's not clear under what license is distributed, I'm not super happy but I can live with it;
3. as you wrote earlier, the test environment needs to be updated to fix the tests. I can help with this, if you allow me to push commits to your branch I will update the GitHub Actions workflow files and the tests should work again (otherwise I can fix this after merging, no problem).

[mirsamantajbakhsh]

Hi @mirsamantajbakhsh, this looks very interesting! Bundle support has been a long desired feature and now you implemented it, so thank you! Here are my thoughts:

1. BundleDecompiler doesn't support windows, I would prefer a cross platform solution but that's ok, however, we have to add some code to show some sort of warning if the user tries to use Obfuscapk on a bundle file on windows;
2. the code for BundleDecompiler is not available and it's not clear under what license is distributed, I'm not super happy but I can live with it;
3. as you wrote earlier, the test environment needs to be updated to fix the tests. I can help with this, if you allow me to push commits to your branch I will update the GitHub Actions workflow files and the tests should work again (otherwise I can fix this after merging, no problem).

Dear @ClaudiuGeorgiu,
Thanks for your kind comments. I have checked the BundleDecompiler. The author has said that the code will be published. I will check regularly if the code is published and Windows support is added to BundleDecompiler.

About write access, I have checked "Allow edits by maintainers". Furthermore, I added you as collaborator to my branch of Obfuscapk.

I'm very proud to take a small part in your amazing project. 🙏

[codecov]

Codecov Report

Merging #121 (9e8a53b) into master (f56d7f8) will decrease coverage by 2.76%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   77.57%   74.81%   -2.77%     
==========================================
  Files          49       50       +1     
  Lines        2453     2589     +136     
  Branches      486      559      +73     
==========================================
+ Hits         1903     1937      +34     
- Misses        422      508      +86     
- Partials      128      144      +16     

Impacted Files	Coverage Δ
src/obfuscapk/cli.py	88.63% <ø> (ø)
src/obfuscapk/toolbundledecompiler.py	25.71% <25.71%> (ø)
src/obfuscapk/obfuscation.py	77.19% <32.50%> (-6.80%)	⬇️
src/obfuscapk/main.py	95.65% <100.00%> (+0.19%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f56d7f8...9e8a53b. Read the comment docs.

[ClaudiuGeorgiu]

I made a few changes and merged your PR, thank you very much @mirsamantajbakhsh, I'm glad you found this project interesting and decided to contribute!