-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyproject.toml and move setup.py logic to setup.cfg. #268
Conversation
I do not have much prior experience with pyproject.toml and setup.cfg. I had to make some concessions on things that I was able to test with python 3.11 on macOS and 3.10 through docker:
|
Tested with the python:3.x containers by running
The error is:
Since 3.5 and 3.6 are officially deprecated, let me know if you want me to ensure support for them. |
I was able to install with 3.5 and 3.6 by hardcoding the Unfortunately I can't run green on itself with 3.5 as the test code has 3.6 syntax, f-strings did not exist yet in 3.5.
|
I was able to run
Let me know how you want to handle this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know how you want to handle this:
- explicitly drop support for python 3.5, and I'll update setup.cfg to reflect that.
- keep support for 3.5 and patch the test.
Let's go ahead and drop support for Python 3.5.
If you will enable the Allow edits from maintainers setting on this PR, I can help fix things up.
This will bring forward compatibility with newer versions of pip. Drop support for Python 3.5 and older. Removed versioned entrypoints, this is not longer relevant now that Python 2 is long deprecated. Fixes CleanCut#267
I'm going to run If you are not against it I'm considering adding mypy to the CI pipeline and start adding type annotation, but in a separate PR. I've found mypy to be very valuable in finding a lot of hidden bugs in our own codebase. |
The CI check cannot run python 3.6 on Ubuntu Latest. Considering 3.6 has been deprecated for over a year that's not surprising. I can skip 3.6 on Ubuntu only since it passes on macOS and Windows. Note that 3.7 will be deprecated at the end of June: https://devguide.python.org/versions/ In case you are wondering about some of the changes decided by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This will bring forward compatibility with newer versions of pip.
Fixes #267
Tested with: