Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imple JAXB with org.glassfish.jaxb and Install it #114

Closed
wants to merge 4 commits into from

Conversation

Ecdcaeb
Copy link
Contributor

@Ecdcaeb Ecdcaeb commented Apr 12, 2024

Summary

Cleanroom has got jakarta xml and transformered the reference of javax.xml for a long time.
But the implement, org.glassfish.jaxb, was not downloaded.
It means such a Exception will be thrown:

Caused by: jakarta.xml.bind.JAXBException: Implementation of Jakarta XML Binding-API has not been found on module path or classpath.
 - with linked exception:
[java.lang.ClassNotFoundException: org.glassfish.jaxb.runtime.v2.ContextFactory]
	at jakarta.xml.bind.ContextFinder.newInstance(ContextFinder.java:250)

I found that the client/server did not download JAXB libraries.

Changes

Install org.glassfish.jaxb and it's dependencies.

Relates

Fix #109 .

Test

ModPack https://github.com/Ecdcaeb/ecdcaeb/raw/main/disk/bin/minecraft/Cleanroom%23109.zip
Running successfully with Forge 2860.
Crash with cleanroom at 26, 27, 28, 29 and so on...
Running successfully with This PR

@Ecdcaeb Ecdcaeb closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with Sword Art Online UI
1 participant