Override slotClick() to fix issues with ItemStackItemHandler
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix fromSlot not being set to empty when it was all moved
set fromSlot to empty
slightly rework the logic in `ModularContainer` to use `putStack()` rename certain variables to make the logic clearer fix issue with using `getStack()` directly
ghzdude
changed the title
ghzdude
changed the title
slotClick() to fix issues with ItemStackItemHandler
brachy84
approved these changes
Dec 30, 2023
miozune
pushed a commit
to GTNewHorizons/ModularUI2
that referenced
this pull request
Feb 7, 2024
…roomMC#49) * fix quickmove skipping if check fix fromSlot not being set to empty when it was all moved * remove empty check in first loop set fromSlot to empty * rework ItemStackItemHandler to extend ItemStackHandler slightly rework the logic in `ModularContainer` to use `putStack()` rename certain variables to make the logic clearer fix issue with using `getStack()` directly * remove `extractItem` override * remove extra call to `putStack()` * undo refactor to ItemStackItemHandler * refactor `slotClick()` to use `putStack()` in appropriate places * move method to match master * add static ints for common mouse button inputs rename dragType to mouseButton * remove unneeded copy call * formatting * forgor a spot * some adjustments * split capability provider and item handler (cherry picked from commit d6a6a74)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks
ItemStackItemHandlerModuleContainerto fix a dupe when shift-clicking items.Adds
putStack()calls toModularContainer::transferItem,ModularContainer::transferStackInSlot, andModularContainer::slotClickso that items are saved to NBT for ItemStackItemHandler.Rename certain variables to make the purpose of the logic in
ModularContainer::transferItemclearerLet me know if this will cause problems with other mods