Add support for skip gif flag #6
Conversation
This adds the ability to disable the posting of gifs in the comments. Includes the addition of a flag, tests and documentation updates
|
Hey, @lwaddicor! thanks for this PR! Looks great! Was wondering, would it be useful if we were to give the option to customize the comment body, instead of specific options to disable gifs? |
|
@all-contributors please add @lwaddicor for code |
|
I've put up a pull request to add @lwaddicor! 🎉 |
There was a problem hiding this comment.
@rheaditi @lwaddicor The PR looks good to me. Just a minor nitpick comment. Please fix the conflict in lib/index.js then we are good to merge this PR. @rheaditi Please test the comments in one the repo, we had faced issues in the final render of the comments in the past.
|
Hey, thanks for the reviews, i will try to get this conflict fixed tommorow. @rheaditi yeah a custom comment comment ability would be a pretty cool feature to add |
|
@lwaddicor @rajanand02 I'm thinking.. let's remove the gifs by default? It was cool at first but it consumes a lot of space in a PRs comment section and consumes bandwidth 😅 |
@rheaditi A small cool/fun element won't hurt 😉 When someone trying the tool for the first time they would definitely love the gif but I agree that It can get annoying and also occupying too much space in the conversation section. Since @lwaddicor added an option to disable it I guess it should be fine. |
…skip-gif-flag � Conflicts: � lib/index.js � src/main.ts � src/utils.ts
…nt into feat/add-skip-gif-flag
I'm easy either way, as long as you can disable it I dont see the harm :) |
|
@lwaddicor the |
@rheaditi my bad, rebuilt it and re-added it |
|
@all-contributors please add @lwaddicor for code |
|
I've put up a pull request to add @lwaddicor! 🎉 |
This adds the ability to disable the posting of gifs in the comments.
Includes the addition of a flag, tests and documentation updates