feature/PHPGL-10 merge with master

.travis.yml

@@ -23,6 +23,7 @@ install:
 
 script:
   - vendor/bin/phpunit --coverage-clover build/logs/clover.xml
+  - vendor/bin/behat
 
 after_script:
   - vendor/bin/coveralls

behat.yml

@@ -0,0 +1,7 @@
+default:
+    autoload:
+        - %paths.base%/vendor/autoload.php
+    suites:
+        default:
+            contexts:
+                - tests\Clearcode\CommandBusConsole\Contexts\CLIContext

composer.json

@@ -13,14 +13,17 @@
         "php": ">=5.5",
         "symfony/framework-bundle": "~2.5",
         "simple-bus/symfony-bridge": "^4.1",
-        "ramsey/uuid": "~3.0"
+        "ramsey/uuid": "~3.0",
+        "symfony/yaml": "~2.5"
     },
     "require-dev": {
         "phpunit/phpunit": "~4.0",
         "satooshi/php-coveralls": "^0.6.1",
         "matthiasnoback/symfony-console-form": "^1.1",
         "symfony/finder": "~2.5",
         "symfony/validator": "~2.5",
+        "symfony/class-loader": "~2.1",
+        "behat/behat": "^3.0",
         "symfony/var-dumper": "~2.5",
         "matthiasnoback/symfony-dependency-injection-test": "0.*"
     },
@@ -33,8 +36,7 @@
             "examples\\Clearcode\\CommandBusConsole\\": "examples"
         }
     },
-    "minimum-stability": "dev",
-    "prefer-stable": true,
+    "minimum-stability": "stable",
     "extra": {
         "branch-alias": {
             "dev-master": "0.2.x-dev"

features/handle_command.feature

@@ -0,0 +1,5 @@
+Feature: Handle command
+
+  Scenario: Successfully handle command
+    When I run command "command-bus:handle SuccessfulCommand"
+    Then command should end successfully

src/Bundle/Command/CommandBusConsoleCommand.php

@@ -16,7 +16,7 @@ class CommandBusConsoleCommand extends ContainerAwareCommand
     protected function configure()
     {
         $this
-            ->setName('command-bus:console')
+            ->setName('command-bus:handle')
             ->setDescription('CLI for command bus.')
             ->addArgument('commandName', InputArgument::REQUIRED)
             ->addArgument('arguments', InputArgument::IS_ARRAY);
@@ -35,7 +35,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
         } catch (CommandConsoleException $e) {
             return $this->handleException($output, $e);
         }
-
         try {
             $this->getContainer()->get('command_bus')->handle($command);
         } catch (\Exception $e) {

src/CommandReflection.php

@@ -37,9 +37,10 @@ public static function fromClass($className)
     public function parameters()
     {
         $commandReflection = new \ReflectionClass($this->commandClass);
-        $commandParameters = $commandReflection->getConstructor()->getParameters();
 
-        return $commandParameters;
+        return $commandParameters = $commandReflection->getConstructor() ?
+            $commandReflection->getConstructor()->getParameters() :
+            [];
     }
 
     /**

tests/Bundle/App/config.yml

@@ -10,4 +10,9 @@ services:
     dummy_command:
         class: tests\Clearcode\CommandBusConsole\Bundle\Mocks\DummyCommandHandler
         tags:
-            - { name: command_handler, handles: tests\Clearcode\CommandBusConsole\Bundle\Mocks\DummyCommand }
+            - { name: command_handler, handles: tests\Clearcode\CommandBusConsole\Bundle\Mocks\DummyCommand }
+
+    successful_command_handler:
+        class: tests\Clearcode\CommandBusConsole\CommandBus\SuccessfulCommandHandler
+        tags:
+            - { name: command_handler, handles: tests\Clearcode\CommandBusConsole\CommandBus\SuccessfulCommand }

tests/Bundle/CLITestCase.php

@@ -18,7 +18,7 @@ abstract class CLITestCase extends WebTestCase
     /** {@inheritdoc} */
     public static function getKernelClass()
     {
-        include_once __DIR__ . '/App/TestKernel.php';
+        include_once __DIR__.'/App/TestKernel.php';
 
         return TestKernel::class;
     }

tests/CommandBus/SuccessfulCommand.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace tests\Clearcode\CommandBusConsole\CommandBus;
+
+final class SuccessfulCommand
+{
+}

tests/CommandBus/SuccessfulCommandHandler.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace tests\Clearcode\CommandBusConsole\CommandBus;
+
+final class SuccessfulCommandHandler
+{
+    public function handle(SuccessfulCommand $successCommand)
+    {
+    }
+}

tests/Contexts/CLIContext.php

@@ -0,0 +1,46 @@
+<?php
+
+namespace tests\Clearcode\CommandBusConsole\Contexts;
+
+use Assert\Assertion;
+use Behat\Behat\Context\Context;
+use Behat\Behat\Context\SnippetAcceptingContext;
+use Clearcode\CommandBusConsole\Bundle\Command\CommandBusConsoleCommand;
+use Symfony\Bundle\FrameworkBundle\Console\Application;
+use Symfony\Component\Console\Input\StringInput;
+use Symfony\Component\Console\Output\StreamOutput;
+use tests\Clearcode\CommandBusConsole\Bundle\App\TestKernel;
+
+class CLIContext implements Context, SnippetAcceptingContext
+{
+    private $app;
+
+    private $status;
+
+    public function __construct()
+    {
+        $kernel = new TestKernel('test', false);
+        $this->app = new Application($kernel);
+        $this->app->setAutoExit(false);
+        $this->app->add(new CommandBusConsoleCommand());
+    }
+
+    /**
+     * @When I run command :command
+     */
+    public function iRunCommand($command)
+    {
+        $input = new StringInput($command);
+        $output = new StreamOutput(fopen('php://memory', 'w'));
+
+        $this->status = $this->app->run($input, $output);
+    }
+
+    /**
+     * @Then command should end successfully
+     */
+    public function commandShouldEndSuccessfully()
+    {
+        Assertion::same($this->status, 0);
+    }
+}