This repository has been archived by the owner on Sep 18, 2018. It is now read-only.
Fix deprecation warnings, fixes #177 #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslowskicc
force-pushed
the
deprecation-warnings
branch
2 times, most recently
from
aae4f61
to
17fe1cf
Compare
mmaslowskicc
force-pushed
the
deprecation-warnings
branch
from
17fe1cf
to
2179da1
Compare
mmaslowskicc
force-pushed
the
deprecation-warnings
branch
from
2179da1
to
7b957ed
Compare
|
Or should I fix the current warnings without checking them during CI builds? (This finds them in several dependencies on Python 3.5, and future changes might cause them to raise more.) |
|
@mmaslowskicc either that, or turn specific packages warnings into errors, that occur in our code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.