This repository has been archived by the owner on Sep 18, 2018. It is now read-only.
Run tests on PyPy, PyPy3, fixes #94 #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -233,7 +233,10 @@ def postgresql_factory(request): | |||
| """ | |||
| proc_fixture = request.getfuncargvalue(process_fixture_name) | |||
|
|
|||
| psycopg2, config = try_import('psycopg2', request) | |||
| if platform.python_implementation() == 'PyPy': | |||
There was a problem hiding this comment.
I don't like this, while I'm not sure if there is a more typical way to run an available package among several supported ones.
There was a problem hiding this comment.
ideally, it would be kept in compat.py for these ifs
There was a problem hiding this comment.
or maybe some modification to try_import?
|
👍 |
MySQL support is not working on PyPy3, since it requires Python 3 features not available there yet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.