Do not hardcode boto3 settings #48
Conversation
src/pytest_dynamodb/factories.py
Outdated
| @@ -141,10 +141,6 @@ def dynamodb_factory(request): | |||
| host=proc_fixture.host, | |||
| port=proc_fixture.port | |||
| ), | |||
| # these args do not matter (we have to put something to them) | |||
| region_name='us-east-1', | |||
There was a problem hiding this comment.
have these as configurable options for regular trio. fixture factory, pytest command line args and pytest ini.
We should be able to configure both presence or the lack of these options as well.
There was a problem hiding this comment.
This can be done in environment variables as in fixture added. End user may have some unknown / unpredictable needs, setups that this plugin IMO should not cover. Also boto3 can read its config file. Environment variables are not the only way. In fact you can pass environment variable which is a path to config file.
We should be able to configure both presence or the lack of these options as well.
What do you mean by lack options ?
Even if there are options for access key, secret key, region, what about other options ? It does not make any sense duplicating every boto3 option and you do not know when new options will be added.
This patch will require end user to be responsible for providing boto3 settings. No need to hardcode them.