Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest7 compatibility #354

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Conversation

derfred
Copy link
Contributor

@derfred derfred commented Feb 10, 2022

Fixes #352.

Changes proposed.

Copy link
Member

@fizyk fizyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this change requires pytest >= 6.2 make sure to update setup.cfg

src/pytest_mysql/factories/process.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #354 (8fdfeab) into main (00ec629) will increase coverage by 0.20%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   61.38%   61.58%   +0.20%     
==========================================
  Files          14       14              
  Lines         303      302       -1     
==========================================
  Hits          186      186              
+ Misses        117      116       -1     
Flag Coverage Δ
linux 61.58% <33.33%> (+0.20%) ⬆️
mariadb 59.93% <33.33%> (+0.19%) ⬆️
mysql 57.61% <33.33%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pytest_mysql/factories/process.py 59.37% <33.33%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303c4da...8fdfeab. Read the comment docs.

@fizyk fizyk merged commit 00c7f14 into ClearcodeHQ:main Feb 11, 2022
@fizyk
Copy link
Member

fizyk commented Feb 11, 2022

@derfred thank you!

@derfred derfred deleted the pytest7_compatibility branch February 11, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with pytest 7.0
3 participants