Tweak #2
Closed
Tweak #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @blueyed for this.
The new version uses category as the reference point to later infer the issue number and counter value. As a consequence, it will return (None, None, None) if the base name doesn't contain a valid category. The new parser allows using file names like '123.feature.1.ext' which are convenient when one wants to use an appropriate extension (e.g. rst, md) to enable syntax highlighting.
* Fix the use of -mtowncrier. twisted#163 * Apply suggestions from code review * Update src/towncrier/test/test_project.py Co-authored-by: Glyph <glyph@twistedmatrix.com>
…n - close twisted#165 This allows for the towncrier to be seamlessly used in non-python projects
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
|
GitHub didn't allow me to add this proposal in the other PR so here's this one... |
|
applied in twisted#166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.