Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications about network issues should only be displayed once #109

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

brandones
Copy link
Contributor

@brandones brandones commented Nov 3, 2023

At present, there is a failure, a notification will be displayed every time document checking happens. If auto-checking is on, it will appear over and over, disappearing and reappearing every few seconds.

This PR makes it so that repeat notifications are suppressed when auto-checking.

Sorry the video is so long, but it shows both the present behavior and new behavior.

output.mp4

@Clemens-E
Copy link
Owner

I will add typings to the status and then merge it, thanks for the PR!
and sorry for not merging this sooner

@Clemens-E Clemens-E merged commit cc2574f into Clemens-E:master Dec 12, 2023
1 check failed
@MartinJDavis93
Copy link

@brandones Thank you, this is a great PR, but there's a slightly inconvenient aspect while working – the notification doesn't close automatically. To close it, you've to click on it, which isn't very convenient. It'd be great if you could fix this. Thanks again.

@Clemens-E
Copy link
Owner

I modified this so the notification hides after 3 Seconds.
You can update the plugin to see the change

@MartinJDavis93
Copy link

I modified this so the notification hides after 3 Seconds. You can update the plugin to see the change

Updated, everything works great! Thank you kindly.

@brandones brandones deleted the error-notifs branch December 14, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants