Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required HL changes for LL- Improve-Sound feature #80

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Required HL changes for LL- Improve-Sound feature #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/mower_comms/src/mower_comms.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,10 +388,9 @@ void handleLowLevelConfig(struct ll_high_level_config *config_pkt) {

// TODO: Handle announced comms_version once required

if (config_pkt->volume >= 0)
volume = config_pkt->volume;
language = config_pkt->language;

// We're not interested in the received langauge setting (yet)

// We're not interested in the received volume setting (yet)

if (config_pkt->type == PACKET_ID_LL_HIGH_LEVEL_CONFIG_REQ || // Config requested
config_pkt->config_bitmask & LL_HIGH_LEVEL_CONFIG_BIT_DFPIS5V != dfp_is_5v) { // Our DFP_IS_5V setting is leading
Expand Down
6 changes: 3 additions & 3 deletions src/open_mower/config/mower_config.sh.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,17 @@ export OM_MOWER_GAMEPAD="xbox360"
# If you manually opened the 3.3V track and solder a bridge to 5V, then you can indicate it here to get full sound support.
# DO NOT enable "OM_DFP_IS_5V=True" if you haven't changed it in real. You might risk your "Raspberry Pico"!
# And even if the Pico isn't expensive, it's a torture to replace it.
# Full details are available here: https://github.com/ClemensElflein/OpenMower/blob/main/Firmware/LowLevel/README-Sound%2C%20DFPIS5V.md
# export OM_DFP_IS_5V=False
#
# Language as ISO-639-1 code string (currently only used by sound).
# Overwrite a previously configure language (i.e. changed by CoverUI)
# Supported languages: en|de
# export OM_LANGUAGE="en"
#
# Sound volume (%)
# Supported values:
# 0-100 = Set sound volume on OM start, ignoring previously set volume level (i.e. by CoverUI)
# -1 = Don't change a previusoly set volume level (i.e. by CoverUI)
# 0-100 = Set sound volume on OM start, ignoring a previously set volume level (i.e. changed by CoverUI)
# -1 = Don't change a previously set volume level (i.e. changed by CoverUI)
# export OM_VOLUME=-1

################################
Expand Down
Loading