Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Deprecated Imports from scipy.misc #138

Merged
merged 5 commits into from
Apr 7, 2022

Conversation

micat001
Copy link
Contributor

@micat001 micat001 commented Apr 1, 2022

PR Motivation

Changes

This PR replaces all import of scipy.misc.imresize with from skimage.transform import resize as imresize and all imports of scipy.misc.imread with from imageio import imread.

It fixes a minor typo in the README groud -> ground as well as updates the requirements.txt to add the new import dependency (scikit-image). I've also updated the argparser in data/prepare_train_data.py to a default dataset_format of kitti_raw as the prior default was not an acceptable choice (kitti when the allowed choices were choices=["kitti_raw", "kitti_odometry", "cityscapes"]).

Results

The results were validated with Python 3.8 and 3.9 and seemed to be approximately equivalent to the repo reported results.

Pose Results

Sequence ATE RE
09 (Pull Request) 0.0195 (std 0.0107) 0.0041 (std 0.0022)
09 (Repo Results) 0.0179 (std. 0.0110) 0.0018 (std. 0.0009)
10 (Pull Request) 0.0148 (std 0.0096) 0.0042 (std 0.0027)
10 (Repo Results) 0.0141 (std 0.0115) 0.0018 (std 0.0011)

Depth Results

Abs Rel Sq Rel RMSE RMSE (log) Acc. 1 Acc. 2 Acc. 3
Pull Request 0.181 1.340 6.222 0.261 0.733 0.908 0.964
Repo Results 0.181 1.341 6.236 0.262 0.733 0.901 0.964

@ClementPinard
Copy link
Owner

LGTM
thank you !

@ClementPinard ClementPinard merged commit f84ede0 into ClementPinard:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants