Replacing Deprecated Imports from scipy.misc #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Motivation
Changes
This PR replaces all import of
scipy.misc.imresize
withfrom skimage.transform import resize as imresize
and all imports ofscipy.misc.imread
withfrom imageio import imread
.It fixes a minor typo in the README
groud -> ground
as well as updates the requirements.txt to add the new import dependency (scikit-image
). I've also updated the argparser in data/prepare_train_data.py to a defaultdataset_format
ofkitti_raw
as the prior default was not an acceptable choice (kitti
when the allowed choices werechoices=["kitti_raw", "kitti_odometry", "cityscapes"]
).Results
The results were validated with Python 3.8 and 3.9 and seemed to be approximately equivalent to the repo reported results.
Pose Results
Depth Results