[Windows] Disks widget shows \\?\Volume{drive ID} instead of drive names

[Scripter17]

Checklist

• I've looked through troubleshooting, known problems, and existing open issues for similar issues.

Describe the issue

Basically just what's in the title

What operating system and version are you using?

Windows 10 22H2

What architecture are you using?

x86

What terminal(s) are you running bottom on?

Regular command prompt (cmd.exe)

What version of bottom are you running?

0.8.0

How did you install bottom?

Through cargo

How can we reproduce this?

1. Open bottom on windows
2. Look at the disks widget

Additional information

No response

[ClementTsang]

That's not really a bug, it's currently intentional behaviour, though I can look to changing it if possible. Windows reports weird-looking drive names with the library I was using.

[Scripter17]

...So the intended behaviour is to... sort alphabetically by drive ID instead of what the drive is named...

I can understand this being a "I can't be bothered to fix this" problem because it's the exact kind of obvious feature windows would make hard (at least without spawning a wmic process each time you want to get the disk info) but this does not at all look like intended behaviour.

I'm really am sorry if I'm coming off as rude but I am just baffled

[ClementTsang]

The original and intended behaviour was sorting by whatever was in the disk name column, yes, especially prior to being able to sort by any column. And the returned name for a drive on Windows has always been this weird name.

I'm fine with changing it to be nicer (if reasonably possible) but it isn't exactly a bug how it currently is, hence why I closed it. If you would prefer, I can reopen this as a feature request.

[ClementTsang]

Looks like #1064 will end up changing this anyway, though currently the behaviour for some drives is that it'll just return a blank name now.

[ClementTsang]

New behaviour is that it'll return whatever sysinfo returns, which generally seems to match whatever it is named in File Explorer. For drives with no name, for now, I instead return No Name, as I'm not sure if leaving it blank would cause confusion.