refactor: migrate disk collection code off of heim, remove heim #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1064 +/- ##
==========================================
- Coverage 26.44% 25.77% -0.67%
==========================================
Files 83 94 +11
Lines 14732 15377 +645
==========================================
+ Hits 3896 3964 +68
- Misses 10836 11413 +577
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ClementTsang
changed the title
ClementTsang
force-pushed
the
migrate_disk_collection
branch
5 times, most recently
from
b4877ad
to
0cf3106
Compare
1 task
ClementTsang
force-pushed
the
migrate_disk_collection
branch
3 times, most recently
from
af948f5
to
17f6862
Compare
ClementTsang
changed the title
ClementTsang
force-pushed
the
migrate_disk_collection
branch
2 times, most recently
from
dec1224
to
412f35b
Compare
|
Follow-up: might be worth moving some of the disk and I/O merging logic here, as we can optimize what's stored in the first place and possibly minimize system API calls. |
Turns out sysinfo lacks a lot of data I need. I can still use it for the Windows disk usage implementation, but I'm probably going to manually implement macos/linux usage and all io usage stats.
ClementTsang
force-pushed
the
migrate_disk_collection
branch
from
3d27ce7
to
a30aac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Migrates existing heim-based disk data collection code off of it to either sysinfo or vendored code based on heim/sysinfo/other sources. This also allows us to remove heim completely from bottom.
Issue
If applicable, what issue does this address?
Closes: #597
Closes: #787
Closes: #812
Closes: #1075
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, doc pages, etc.)