Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated value_of and is_present, no warnings, clap 3.2.2 #1008

Merged

Conversation

spital
Copy link
Contributor

@spital spital commented Jan 29, 2023

Description

Replaced deprecated value_of and is_present, builds with no warnings, clap 3.2.2

Testing

Tested on Mac OS X and Fedora 36 with rust 1.67

cargo test
btm

Checklist

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov-commenter
Copy link

Codecov Report

Base: 20.71% // Head: 20.72% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3b27a7a) compared to base (9ad1d8f).
Patch coverage: 74.50% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1008   +/-   ##
=======================================
  Coverage   20.71%   20.72%           
=======================================
  Files          75       75           
  Lines       14680    14681    +1     
=======================================
+ Hits         3041     3042    +1     
  Misses      11639    11639           
Impacted Files Coverage Δ
src/options.rs 41.94% <72.91%> (+0.07%) ⬆️
src/bin/main.rs 36.58% <100.00%> (ø)
src/clap.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@ClementTsang ClementTsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small nits, if you don't think they're worth fixing just let me know, and I'll merge as is.

src/bin/main.rs Outdated Show resolved Hide resolved
src/clap.rs Outdated Show resolved Hide resolved
src/options.rs Outdated Show resolved Hide resolved
Copy link
Owner

@ClementTsang ClementTsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, though I might need to update that Cargo.lock file. I'll handle that though and merge in a bit.

@ClementTsang ClementTsang merged commit 021a727 into ClementTsang:master Feb 1, 2023
@ClementTsang
Copy link
Owner

@all-contributors please add @spital for code.

@allcontributors
Copy link
Contributor

@ClementTsang

I've put up a pull request to add @spital! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants