New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced deprecated value_of
and is_present
, no warnings, clap 3.2.2
#1008
Replaced deprecated value_of
and is_present
, no warnings, clap 3.2.2
#1008
Conversation
Codecov ReportBase: 20.71% // Head: 20.72% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1008 +/- ##
=======================================
Coverage 20.71% 20.72%
=======================================
Files 75 75
Lines 14680 14681 +1
=======================================
+ Hits 3041 3042 +1
Misses 11639 11639
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small nits, if you don't think they're worth fixing just let me know, and I'll merge as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, though I might need to update that Cargo.lock
file. I'll handle that though and merge in a bit.
@all-contributors please add @spital for code. |
I've put up a pull request to add @spital! 🎉 |
Description
Replaced deprecated
value_of
andis_present
, builds with no warnings, clap 3.2.2Testing
Tested on Mac OS X and Fedora 36 with rust 1.67
cargo test btm
Checklist
cargo fmt
)README.md
, help menu, doc pages, etc.)