Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support 3-char hex colours #1022

Merged
merged 1 commit into from Feb 18, 2023

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Feb 18, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Support three-character hex colours (e.g. "#fff").

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Base: 20.96% // Head: 21.31% // Increases project coverage by +0.34% 🎉

Coverage data is based on head (1339bc2) compared to base (edc61d4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
+ Coverage   20.96%   21.31%   +0.34%     
==========================================
  Files          75       75              
  Lines       14694    14754      +60     
==========================================
+ Hits         3081     3145      +64     
+ Misses      11613    11609       -4     
Impacted Files Coverage Δ
src/canvas/canvas_styling/colour_utils.rs 97.53% <100.00%> (+3.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang marked this pull request as ready for review February 18, 2023 06:41
@ClementTsang ClementTsang merged commit f89b243 into master Feb 18, 2023
@ClementTsang ClementTsang deleted the support_three_digit_hex_colours branch February 18, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant