Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate network collection to sysinfo #1041

Merged
merged 3 commits into from Mar 4, 2023

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Mar 3, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Remove the relevant heim feature/code and switch fully to sysinfo for network collection.

Issue

If applicable, what issue does this address?

Part of #812.

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang
Copy link
Owner Author

ClementTsang commented Mar 3, 2023

I had apparently done this migration before (#833) but then reverted it (d99f41f), and never changed it back after again... not sure if there was a reason. Double check on all platforms before merging this one!

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 55.40% and project coverage change: +0.36 🎉

Comparison is base (caba611) 26.17% compared to head (a1ac11b) 26.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1041      +/-   ##
==========================================
+ Coverage   26.17%   26.54%   +0.36%     
==========================================
  Files          80       80              
  Lines       14622    14574      -48     
==========================================
+ Hits         3827     3868      +41     
+ Misses      10795    10706      -89     
Flag Coverage Δ
macos-12 27.31% <55.40%> (+0.27%) ⬆️
ubuntu-latest 27.08% <55.40%> (+0.30%) ⬆️
windows-2019 27.02% <55.40%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app.rs 0.14% <ø> (+<0.01%) ⬆️
src/app/data_harvester.rs 0.00% <0.00%> (ø)
src/app/data_harvester/network.rs 20.00% <ø> (ø)
src/app/data_harvester/network/sysinfo.rs 0.00% <0.00%> (ø)
src/options.rs 75.47% <ø> (ø)
src/app/filter.rs 97.61% <97.61%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang marked this pull request as ready for review March 4, 2023 02:24
@ClementTsang ClementTsang merged commit 994c11e into master Mar 4, 2023
@ClementTsang ClementTsang deleted the migrate_network_collection branch March 4, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant