Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add current battery charging state, update field names #1106

Merged
merged 1 commit into from Apr 19, 2023

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Apr 19, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Adds an additional field to clarify the current charging state, and update one of the fields from consumption to rate. Also tweak some auto text hiding logic.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang changed the title other: add current battery charging state, update field names feature: add current battery charging state, update field names Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (3e1aa9c) 25.79% compared to head (988d740) 25.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
- Coverage   25.79%   25.74%   -0.06%     
==========================================
  Files          94       94              
  Lines       15505    15540      +35     
==========================================
  Hits         4000     4000              
- Misses      11505    11540      +35     
Flag Coverage Δ
macos-12 27.09% <0.00%> (-0.07%) ⬇️
ubuntu-latest 27.05% <0.00%> (-0.07%) ⬇️
windows-2019 27.10% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/data_harvester/batteries/battery.rs 0.00% <0.00%> (ø)
src/canvas/widgets/battery_display.rs 0.00% <0.00%> (ø)
src/data_conversion.rs 14.54% <0.00%> (-0.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang marked this pull request as ready for review April 19, 2023 04:46
@ClementTsang ClementTsang merged commit 1c95411 into master Apr 19, 2023
32 checks passed
@ClementTsang ClementTsang deleted the more_battery_details branch April 19, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant