Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: remaining changes needed to get android to build #1199

Merged
merged 3 commits into from Jun 11, 2023

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jun 10, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.30 🎉

Comparison is base (2ba7394) 30.98% compared to head (6f48fa5) 31.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1199      +/-   ##
==========================================
+ Coverage   30.98%   31.29%   +0.30%     
==========================================
  Files          97       97              
  Lines       16545    16385     -160     
==========================================
  Hits         5127     5127              
+ Misses      11418    11258     -160     
Flag Coverage Δ
macos-12 33.16% <0.00%> (+0.19%) ⬆️
ubuntu-latest 32.85% <0.00%> (+0.33%) ⬆️
windows-2019 33.42% <0.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/data_harvester.rs 0.00% <0.00%> (ø)
src/app/data_harvester/disks.rs 79.26% <ø> (ø)
src/app/data_harvester/disks/unix.rs 0.00% <0.00%> (ø)
src/app/data_harvester/disks/windows.rs 0.00% <0.00%> (ø)
src/canvas/dialogs/dd_dialog.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang marked this pull request as ready for review June 11, 2023 02:20
Base automatically changed from disk_io_fallback to master June 11, 2023 04:01
@ClementTsang ClementTsang force-pushed the android_fallback branch 3 times, most recently from 8769a11 to bd55bd2 Compare June 11, 2023 04:34
@ClementTsang ClementTsang merged commit 2a354f7 into master Jun 11, 2023
32 checks passed
@ClementTsang ClementTsang deleted the android_fallback branch June 11, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant