Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: fix humantime-related documentation, add tests, support numbers + strings in toml #1220

Merged
merged 3 commits into from Jun 22, 2023

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jun 21, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Few things:

  • Updates the documentation for default_time_value and time_delta to show support for human times.
  • Update the errors to be more human-friendly.
  • Support both numerical values (in ms) or strings in the config, along with tests.
  • Also update the args' help to be more in-line with what's supported.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 91.22% and project coverage change: +0.14 🎉

Comparison is base (6f1a8f7) 31.62% compared to head (036c96e) 31.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
+ Coverage   31.62%   31.77%   +0.14%     
==========================================
  Files          97       97              
  Lines       16535    16571      +36     
==========================================
+ Hits         5230     5265      +35     
- Misses      11305    11306       +1     
Flag Coverage Δ
macos-12 33.35% <91.22%> (+0.15%) ⬆️
ubuntu-latest 33.35% <91.22%> (+0.14%) ⬆️
windows-2019 33.61% <91.22%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/data_table/column.rs 5.22% <ø> (ø)
src/constants.rs 98.81% <ø> (ø)
src/options.rs 81.36% <89.36%> (+0.73%) ⬆️
src/args.rs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang merged commit 0b7f4c7 into master Jun 22, 2023
34 checks passed
@ClementTsang ClementTsang deleted the more_humantime branch June 22, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant