Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arg test; add config tests #126

Merged
merged 8 commits into from
Apr 23, 2020
Merged

Update arg test; add config tests #126

merged 8 commits into from
Apr 23, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Apr 23, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

With 1.4.3 we can avoid the weird test-binary thing.

Furthermore, finally add config tests, and do a refactor of current error handling.

Issue

If applicable, what issue does this address?

Closes: #

Type of change

Remove the irrelevant ones:

  • Other (something else - please specify if relevant):

Test methodology

Please state how this was tested:

Please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

Checklist

Please ensure all are ticked (and actually done):

  • Change has been tested to work
  • Areas your change affects have been linted using rustfmt
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced unless intended
  • Documentation has been added/updated if needed
  • No merge conflicts arise from the change

Other information

Provide any other relevant information:

@ClementTsang ClementTsang changed the title refactor: update arg tests to use new binary env Update arg test; add config tests Apr 23, 2020
@ClementTsang ClementTsang merged commit 99fe0a1 into master Apr 23, 2020
@ClementTsang ClementTsang deleted the update_tests branch April 23, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant