Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add scroll indicator to keep track of table position in widgets. #333

Merged
merged 5 commits into from Nov 28, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Nov 28, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Adds the option to enable an "out of" indicator for scrollable table widgets (using --show_table_scroll_position).

For example:

image

Issue

If applicable, what issue does this address?

Closes: #

Type of change

Remove the irrelevant ones:

  • New feature (non-breaking change which adds functionality)

Test methodology

If relevant, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

If relevant, all of these platforms should be tested.

Checklist

If relevant, ensure the following have been met:

  • Change has been tested to work, and does not cause new breakage unless intended
  • Code has been self-reviewed
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • Passes CI pipeline (clippy check and cargo test check)
  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information to this change:

@ClementTsang ClementTsang changed the title Out of indicator feature: Add scroll indicator to keep track of table position in widgets. Nov 28, 2020
@ClementTsang ClementTsang marked this pull request as ready for review November 28, 2020 19:02
@ClementTsang ClementTsang merged commit 3260ff4 into master Nov 28, 2020
@ClementTsang ClementTsang deleted the out_of_indicator branch November 28, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant