feature: Hide SWAP graph and legend in normal mode if SWAP is 0 #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly, note this currently won't affect basic mode. There is code changes due to it, but instead, we'll just display `0B/0B` instead. I'm personally not really sure if we want to get rid of it in basic mode, since it'll leave an ugly gap in that mode. Anyways, this change is mainly for the normal mode. All this does is hide the legend entry and chart if the total SWAP drops to 0 KB. That's it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change and what it does. If relevant, please provide screenshots of what results from the change:
Firstly, note this currently won't affect basic mode. There is code changes due to it, but instead, we'll just display
0B/0Binstead. I'm personally not really sure if we want to get rid of it in basic mode, since it'll leave an ugly gap in that mode.Anyways, this change is mainly for the normal mode. All this does is hide the legend entry and chart if the total SWAP drops to 0 KB. It also has a small change to do a unit check on the memory used, as well as slightly adjusting the calculation we use.
Issue
If applicable, what issue does this address?
Closes: #370
Type of change
Remove the irrelevant ones:
Test methodology
If relevant, please state how this was tested:
Furthermore, please tick which platforms this change was tested on:
If relevant, all of these platforms should be tested.
Checklist
If relevant, ensure the following have been met:
cargo testcheck)cargo fmt)Other information
Provide any other relevant information to this change: