Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update various deps as per 2021-02-19 #420

Merged
merged 5 commits into from Feb 19, 2021

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Feb 19, 2021

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Update some dependencies as per 2021-02-19

Issue

If applicable, what issue does this address?

Closes: #

Type of change

Remove the irrelevant ones:

  • Other (something else - please specify): Dependency update

Test methodology

If relevant, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

If relevant, all of these platforms should be tested.

Checklist

If relevant, ensure the following have been met:

  • Change has been tested to work, and does not cause new breakage unless intended
  • Code has been self-reviewed
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • Passes CI pipeline (clippy check and cargo test check)
  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information to this change:

@ClementTsang
Copy link
Owner Author

Yikes, huge performance regressions with the crossterm + tui-rs update... I'll take a look but potentially will hold off on this for now...

@ClementTsang
Copy link
Owner Author

The issue was crossterm and how it was polling. Reverting that resulted in more normal performance numbers.

@ClementTsang ClementTsang merged commit cb1191f into master Feb 19, 2021
@ClementTsang ClementTsang deleted the update_deps_2021-02-19 branch February 19, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant