Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add basic page up/down scrolling #646

Merged
merged 3 commits into from
Dec 27, 2021
Merged

feature: add basic page up/down scrolling #646

merged 3 commits into from
Dec 27, 2021

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Dec 27, 2021

Description

A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:

Adds page up/down scrolling support to respectively scroll up/down by a full page.

Note that this is mostly just to get the feature out for those interested, and is admittedly a bit rushed - I will be rewriting all logic involving event handling as part of state refactor anyways, so this will also get changed in the work done there, and therefore, I kinda just sped through this.

Issue

If applicable, what issue does this address?

Closes: #620

Testing

If relevant, please state how this was tested. All changes must be tested to work:

Please also indicate which platforms were tested. All platforms directly affected by the change must be tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts

This is mostly just to get the feature out - I will be rewriting this
as part of state refactor anyways.
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2021

Codecov Report

Merging #646 (a70b2f9) into master (eaff52c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #646      +/-   ##
=========================================
- Coverage    7.16%   7.14%   -0.03%     
=========================================
  Files          52      52              
  Lines        8285    8315      +30     
=========================================
  Hits          594     594              
- Misses       7691    7721      +30     
Impacted Files Coverage Δ
src/app.rs 0.00% <0.00%> (ø)
src/canvas.rs 0.00% <0.00%> (ø)
src/constants.rs 0.00% <ø> (ø)
src/lib.rs 0.00% <0.00%> (ø)
src/utils/logging.rs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c92cfc6...a70b2f9. Read the comment docs.

@ClementTsang
Copy link
Owner Author

Going to be ignoring codecov for this, this code is going to be dead in (hopefully) a few weeks anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PageUp/PageDn support on Process Widget
2 participants