Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment: add arm and aarch deb generation #737

Closed
wants to merge 15 commits into from

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented May 25, 2022

Description

A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:

Adds arm and aarch64 as targets to build .deb files for in the deployment and nightly workflows.

Issue

If applicable, what issue does this address?

Closes: #736

Testing

Relevant workflows should be run:

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts

@ClementTsang ClementTsang changed the title deployment: add armv7 and aarch deb gen deployment: add armv7 and aarch deb generation May 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #737 (537ae2d) into master (42909db) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #737   +/-   ##
=======================================
  Coverage   24.20%   24.20%           
=======================================
  Files          56       56           
  Lines       12925    12925           
=======================================
  Hits         3128     3128           
  Misses       9797     9797           
Impacted Files Coverage Δ
build.rs 24.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42909db...537ae2d. Read the comment docs.

@ClementTsang ClementTsang force-pushed the cargo_deb_arm branch 4 times, most recently from 6a52135 to 36b0762 Compare May 25, 2022 18:42
@ClementTsang ClementTsang changed the title deployment: add armv7 and aarch deb generation deployment: add arm and aarch deb generation May 25, 2022
@ClementTsang
Copy link
Owner Author

ClementTsang commented May 25, 2022

Might want to wait for cross-rs/cross#716 to potentially have some developments so I could potentially easily do this with cross, after some messing around, it seems like running cargo deb on ARM via GHA is kinda messy...

I might still mess around with this in the meantime though.

@ClementTsang ClementTsang force-pushed the cargo_deb_arm branch 6 times, most recently from 55baa1c to a6d3569 Compare May 25, 2022 20:47
@ClementTsang
Copy link
Owner Author

ClementTsang commented May 25, 2022

Gonna close this for now, I'll open a new PR with a slightly less awful solution.

@ClementTsang ClementTsang deleted the cargo_deb_arm branch May 27, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bottom not install problem with libc6:amd64
2 participants