Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix CPU 'all' label missing on small sizes #953

Merged
merged 1 commit into from Jan 4, 2023

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jan 4, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Fixes the "All" label being missing on small windows. This was a regression due to #918. We work around it by moving the width skip check into the implementors.

Before vs after:

image

Issue

If applicable, what issue does this address?

Closes: #956

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Base: 20.72% // Head: 20.69% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (74d216d) compared to base (7c53f08).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
- Coverage   20.72%   20.69%   -0.03%     
==========================================
  Files          75       75              
  Lines       14627    14643      +16     
==========================================
  Hits         3031     3031              
- Misses      11596    11612      +16     
Impacted Files Coverage Δ
src/components/data_table/draw.rs 0.00% <0.00%> (ø)
src/widgets/cpu_graph.rs 0.00% <0.00%> (ø)
src/widgets/disk_table.rs 0.00% <0.00%> (ø)
src/widgets/process_table/proc_widget_data.rs 9.52% <0.00%> (-0.20%) ⬇️
src/widgets/process_table/sort_table.rs 0.00% <0.00%> (ø)
src/widgets/temperature_table.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang force-pushed the fix_cpu_all_small branch 2 times, most recently from c71bc38 to 80942ab Compare January 4, 2023 06:19
@ClementTsang ClementTsang changed the title bug: fix CPU all label being missing on small windows bug: fix CPU 'all' label missing on small sizes Jan 4, 2023
@ClementTsang ClementTsang force-pushed the fix_cpu_all_small branch 2 times, most recently from 74d216d to f85a807 Compare January 4, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] CPU "all" label is missing with small widget sizes
2 participants