Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: follow .deb naming conventions #969

Merged
merged 15 commits into from Jan 12, 2023
Merged

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jan 12, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Change the .deb file generation back to following standard naming conventions.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

See this nightly run.

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang force-pushed the follow_deb_naming_conventions branch 3 times, most recently from cbec896 to e3eac32 Compare January 12, 2023 06:05
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Base: 20.68% // Head: 20.68% // No change to project coverage 👍

Coverage data is based on head (7a3758e) compared to base (48cd29f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #969   +/-   ##
=======================================
  Coverage   20.68%   20.68%           
=======================================
  Files          75       75           
  Lines       14653    14653           
=======================================
  Hits         3031     3031           
  Misses      11622    11622           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang marked this pull request as ready for review January 12, 2023 08:23
@ClementTsang ClementTsang merged commit fffeb20 into master Jan 12, 2023
@ClementTsang ClementTsang deleted the follow_deb_naming_conventions branch January 12, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants