Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSOAP-2940: add aria label to ToastNotification close button #570

Merged
merged 2 commits into from Dec 4, 2020
Merged

SSOAP-2940: add aria label to ToastNotification close button #570

merged 2 commits into from Dec 4, 2020

Conversation

jonah-clever
Copy link
Contributor

@jonah-clever jonah-clever commented Dec 4, 2020 •
edited

Jira:
https://clever.atlassian.net/browse/SSOAP-2940

Overview:
Add aria-label to ToastNotification close button to make it readable by screen readers

Testing:

Manually confirmed aria label is present on correct element

  • Unit tests
  • Manual tests:
    • Chrome
    • Safari
    • IE11

Roll Out:
100

  • Before merging:

    • Bumped version in package.json
      • New component or backward-compatible component feature change? Run npm version minor

  • After merging:

    • Deployed updated docs (make deploy-docs)
    • Posted in #eng if I made a breaking change to a beta component

@pickabot pickabot bot requested a review from nbhatia823 December 4, 2020 01:44
nbhatia823
nbhatia823 approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@nbhatia823 nbhatia823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@jonah-clever jonah-clever merged commit 855fb74 into master Dec 4, 2020
@jonah-clever jonah-clever mentioned this pull request Dec 11, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbhatia823 nbhatia823 nbhatia823 approved these changes

Assignees

@nbhatia823 nbhatia823

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonah-clever @nbhatia823