Add Ability to define logout_endpoint and its binding in order to generate a proper metadata file #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Redirect, Default:HTTP-Redirect) to fix the generated metadata file
Closed
mcab
requested changes
Feb 3, 2021
There was a problem hiding this comment.
Looks good!
Changing the default behavior of create_metadata seems like test cases might break.
Lines 65 to 70 in 9395913
Is it possible to fix those cases and add ones to test the changing of Binding and Location?
Co-authored-by: Mark Cabanero <me@markcabanero.com>
miguelfreitas93
commented
Feb 3, 2021
| @@ -79,8 +79,8 @@ create_metadata = (entity_id, assert_endpoint, signing_certificates, encryption_ | |||
| .concat encryption_cert_descriptors | |||
| .concat [ | |||
| 'md:SingleLogoutService': | |||
| '@Binding': 'urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect' | |||
| '@Location': assert_endpoint | |||
| '@Binding': 'urn:oasis:names:tc:SAML:2.0:bindings:' + logout_binding | |||
There was a problem hiding this comment.
logout_binding should be validated with a whitelist
miguelfreitas93
commented
Feb 3, 2021
| '@Binding': 'urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect' | ||
| '@Location': assert_endpoint | ||
| '@Binding': 'urn:oasis:names:tc:SAML:2.0:bindings:' + logout_binding | ||
| '@Location': logout_endpoint |
There was a problem hiding this comment.
logout_endpoint should be validated if it is a valid URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version the SingleLogoutService Location is the same as Assertion Location, which is wrong because both can be different. Also it was added the ability to choose the binding of SingleLogoutService which can be "HTTP-POST" and "HTTP-Redirect"