Fix uncaught error "SessionIndex not an attribute of AuthnStatement" #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagate thrown error for missing session index
|
This is causing major crashes to our service |
|
@mcab any chance of getting this into master and the next release? |
mcab
approved these changes
Dec 4, 2020
|
Ack, I didn't look at inflight PRs too closely. @sebreh, do you believe that #192 fulfills the issue described here? I believe that the additional |
|
@mcab yep, that sounds like it would cover this case. Happy for you to close this after merging that. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an existing error being thrown from within
get_session_infothat is not checked by the caller and therefore not forwarded to the callback chain and as such, is causing the module to crash if triggered. Additionally, there was no test case for this error case. This PR includes both the fix to propagate the error and the missing test case.