feat(cc-logs-instances): add tooltips to commit label and instance index

CleverCloud · Apr 11, 2024 · 438751c · 438751c
1 parent 7a95572
commit 438751c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/src/components/cc-logs-instances/cc-logs-instances.js b/src/components/cc-logs-instances/cc-logs-instances.js
@@ -512,18 +512,21 @@ export class CcLogsInstances extends LitElement {
 
   _renderCommit (commit) {
     return html`
-      <span class="commit">
+      <span class="commit" title=${i18n('cc-logs-instances.commit.title', { commit })}>
         ${commit.substring(0, 7)}
       </span>`
     ;
   }
 
   _renderInstanceIndex (instance) {
+    const title = instance.kind === 'BUILD'
+      ? i18n('cc-logs-instances.instance.build')
+      : i18n('cc-logs-instances.instance.index', { index: instance.index });
+
     return html`
-      <span class="instance-index">
+      <span class="instance-index" title=${title}>
         ${instance.kind === 'BUILD' ? html`
-            <cc-icon .icon=${iconBuildInstance}
-                     a11y-name="${i18n('cc-logs-instances.build.a11y-name')}"></cc-icon>
+            <cc-icon .icon=${iconBuildInstance}></cc-icon>
           ` : ''}
         ${instance.kind !== 'BUILD' ? html`
           ${instance.index}

diff --git a/src/translations/translations.en.js b/src/translations/translations.en.js
@@ -500,9 +500,9 @@ export const translations = {
   'cc-logs-control.wrap-lines': `Force lines wrap`,
   //#endregion
   //#region cc-logs-instances
-  'cc-logs-instances.build.a11y-name': `Instance dedicated to build`,
   'cc-logs-instances.cold.empty': `No instance`,
   'cc-logs-instances.cold.header': `Instances`,
+  'cc-logs-instances.commit.title': ({ commit }) => `Deployed commit: ${commit}`,
   'cc-logs-instances.deleted.header': `Deleted instances`,
   'cc-logs-instances.deploying.header': `Deployment in progress`,
   'cc-logs-instances.deployment.deployed': `Deployed`,
@@ -512,6 +512,8 @@ export const translations = {
   'cc-logs-instances.deployment.state.wip': `Deployment in progress`,
   'cc-logs-instances.ghost.header': `Ghost instances`,
   'cc-logs-instances.ghost.notice': `Some unwanted instances are still running, but will soon be destroyed by our scheduler. You can contact support to get more information.`,
+  'cc-logs-instances.instance.build': `Build instance`,
+  'cc-logs-instances.instance.index': ({ index }) => `Instance #${index}`,
   'cc-logs-instances.instance.state.deleted': `Deleted instance`,
   'cc-logs-instances.instance.state.deploying': `Deploying instance`,
   'cc-logs-instances.instance.state.running': `Running instance`,

diff --git a/src/translations/translations.fr.js b/src/translations/translations.fr.js
@@ -513,9 +513,9 @@ export const translations = {
   'cc-logs-control.wrap-lines': `Forcer le retour à la ligne`,
   //#endregion
   //#region cc-logs-instances
-  'cc-logs-instances.build.a11y-name': `Instance dédiée au build`,
   'cc-logs-instances.cold.empty': `Aucune instance`,
   'cc-logs-instances.cold.header': `Instances`,
+  'cc-logs-instances.commit.title': ({ commit }) => `Commit déployé: ${commit}`,
   'cc-logs-instances.deleted.header': `Instances supprimées`,
   'cc-logs-instances.deploying.header': `Déploiement en cours`,
   'cc-logs-instances.deployment.deployed': `Déployée`,
@@ -525,6 +525,8 @@ export const translations = {
   'cc-logs-instances.deployment.state.wip': `Déploiement en cours`,
   'cc-logs-instances.ghost.header': `Instances fantômes`,
   'cc-logs-instances.ghost.notice': `Des instances indésirables sont toujours en cours d'exécution, mais seront bientôt détruites par notre orchestrateur. Pour en savoir plus, vous pouvez contacter le support.`,
+  'cc-logs-instances.instance.build': `Instance de build`,
+  'cc-logs-instances.instance.index': ({ index }) => `Instance #${index}`,
   'cc-logs-instances.instance.state.deleted': `Instance supprimée`,
   'cc-logs-instances.instance.state.deploying': `Instance en cours de déploiement`,
   'cc-logs-instances.instance.state.running': `Instance démarrée`,