Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stylelint #122

Closed
hsablonniere opened this issue May 4, 2020 · 1 comment 路 Fixed by #529, #644 or #693
Closed

Add stylelint #122

hsablonniere opened this issue May 4, 2020 · 1 comment 路 Fixed by #529, #644 or #693
Assignees
@Galimede
Labels
maintenance Code refactoring, project structure, dev tooling (storybook, dev server, npm tasks...)
Projects
Project board - Clever Components
Milestone
Dev tooling and a...

Comments

@hsablonniere
Copy link
Member

It was brought to my attention that stylelint handles CSS in template literals.

This means our custom ESLint rule for to sort CSS declarations in JavaScript LitElement component files is useless and not the right approach 馃槶
@hsablonniere hsablonniere added the maintenance Code refactoring, project structure, dev tooling (storybook, dev server, npm tasks...) label Mar 8, 2022
@hsablonniere
Copy link
Member Author

NOTE: Our ESLint rule only checks for order but does not enforce any format

@hsablonniere hsablonniere added this to Discuss in Project board - Clever Components via automation Jul 18, 2022
@Galimede Galimede self-assigned this Aug 4, 2022
@Galimede Galimede moved this from Discuss to WiP in Project board - Clever Components Aug 4, 2022
@Galimede Galimede mentioned this issue Aug 8, 2022
Merged
Galimede added a commit that referenced this issue Dec 1, 2022
@Galimede
feat(stylelint): add new tool
7688fd4 
Fixes: #122
Galimede added a commit that referenced this issue Dec 1, 2022
@Galimede
feat(stylelint): add new tool
76e75b3 
Fixes: #122
Project board - Clever Components automation moved this from WiP to Unreleased Dec 1, 2022
@github-actions github-actions bot mentioned this issue Dec 1, 2022
Merged
@hsablonniere hsablonniere moved this from Unreleased to Done in Project board - Clever Components Dec 5, 2022
@Galimede Galimede mentioned this issue Jan 27, 2023
Merged
Galimede added a commit that referenced this issue Feb 7, 2023
@Galimede
docs: add new Stylelint ADR
f670993 
Fixes #122
Galimede added a commit that referenced this issue Feb 9, 2023
@Galimede
docs: add new Stylelint ADR
2fa3656 
Fixes #122
Galimede added a commit that referenced this issue Feb 13, 2023
@Galimede
docs: add new Stylelint ADR
1d4fb29 
Fixes #122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Galimede Galimede

Labels
maintenance Code refactoring, project structure, dev tooling (storybook, dev server, npm tasks...)
Projects
No open projects
Project board - Clever Components
Done
Milestone
Dev tooling and automation
2 participants
@hsablonniere @Galimede