Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc-button: implement parts of ARIA API #699

Closed
florian-sanders-cc opened this issue Feb 6, 2023 · 0 comments · Fixed by #830 or #876
Closed

cc-button: implement parts of ARIA API #699

florian-sanders-cc opened this issue Feb 6, 2023 · 0 comments · Fixed by #830 or #876
Assignees
@pdesoyres-cc
Labels
a11y Related to accessibility enhancement New feature or request
Milestone
logs

Comments

@florian-sanders-cc
Copy link
Contributor

florian-sanders-cc commented Feb 6, 2023 •
edited

Context

There are some situations where we need to add ARIA attributes to make a button accessible.
To name a few:

The only way to do this is to mimic the ARIA API by adding props to our cc-button.
We'll need to make sure these props are properly namespaced to avoid clashing with actual ARIA.

(Once Accessibility Object Model is available 🙄 we'll be able to simplify this but we cannot really wait for it)
@florian-sanders-cc florian-sanders-cc added enhancement New feature or request a11y Related to accessibility labels Feb 6, 2023
@florian-sanders-cc florian-sanders-cc mentioned this issue Mar 29, 2023
Merged
7 tasks
@florian-sanders-cc florian-sanders-cc mentioned this issue Sep 15, 2023
Merged
@pdesoyres-cc pdesoyres-cc mentioned this issue Sep 28, 2023
Closed
@pdesoyres-cc pdesoyres-cc self-assigned this Oct 11, 2023
@pdesoyres-cc pdesoyres-cc added this to the logs milestone Oct 11, 2023
pdesoyres-cc added a commit that referenced this issue Oct 12, 2023
@pdesoyres-cc
feat(cc-button): implement parts of ARIA API
c3f439a 
- add `a11yExpanded` property for setting `aria-expanded` attribute on the inner button.
- add `a11yPressed` property for setting `aria-pressed` attribute on the inner button.

Fixes #699
pdesoyres-cc added a commit that referenced this issue Oct 23, 2023
@pdesoyres-cc
feat(cc-button): implement parts of ARIA API
e9e5c02 
- add `a11yExpanded` property for setting `aria-expanded` attribute on the inner button.
- add `a11yPressed` property for setting `aria-pressed` attribute on the inner button.

Fixes #699
pdesoyres-cc added a commit that referenced this issue Oct 27, 2023
@pdesoyres-cc
feat(cc-button): implement parts of ARIA API
551ea7d 
- add `a11yExpanded` property for setting `aria-expanded` attribute on the inner button.
- add `a11yPressed` property for setting `aria-pressed` attribute on the inner button.

Fixes #699
pdesoyres-cc added a commit that referenced this issue Nov 2, 2023
@pdesoyres-cc
feat(cc-button): implement parts of ARIA API
7090253 
- add `a11yExpanded` property for setting `aria-expanded` attribute on the inner button.
- add `a11yPressed` property for setting `aria-pressed` attribute on the inner button.

Fixes #699
pdesoyres-cc added a commit that referenced this issue Nov 8, 2023
@pdesoyres-cc
feat(cc-button): implement parts of ARIA API
014c592 
- add `a11yExpanded` property for setting `aria-expanded` attribute on the inner button.
- add `a11yPressed` property for setting `aria-pressed` attribute on the inner button.

Fixes #699
@clevercloud-ci clevercloud-ci mentioned this issue Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdesoyres-cc pdesoyres-cc

Labels
a11y Related to accessibility enhancement New feature or request
Projects
None yet
Milestone
logs
2 participants
@florian-sanders-cc @pdesoyres-cc