Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

legacy cc-pricing-header (version < 11.0.0): does not work with chrome > 114 #787

Closed
florian-sanders-cc opened this issue Jun 22, 2023 · 1 comment · Fixed by #782
Closed

legacy cc-pricing-header (version < 11.0.0): does not work with chrome > 114 #787

florian-sanders-cc opened this issue Jun 22, 2023 · 1 comment · Fixed by #782
Assignees
@florian-sanders-cc
Labels
bug Something isn't working

Comments

@florian-sanders-cc
Copy link
Contributor

Context

The currency and zone selects do not work on Chrome > 114.

There is a conflict between popover used by Shoelace and the new Popover API released on Chrome.

Solution

Since the Website is the only consumer of the cc-pricing-header and it uses the version 7.9.0 of this component, we will update the Shoelace dependency to fix this issue and release it in a 7.13.0.

The 7.13.0 version of cc-pricing-header will be the only working version on Chrome below the 11.0.0 version of the components.
@florian-sanders-cc florian-sanders-cc added the bug Something isn't working label Jun 22, 2023
@florian-sanders-cc florian-sanders-cc self-assigned this Jun 22, 2023
florian-sanders-cc added a commit that referenced this issue Jun 22, 2023
@florian-sanders-cc
fix(cc-pricing-header): update shoelace and adapt to breaking changes
8a6ba51 
Fixes #787
@florian-sanders-cc florian-sanders-cc mentioned this issue Jun 22, 2023
Merged
@florian-sanders-cc florian-sanders-cc linked a pull request Jun 22, 2023 that will close this issue
legacy pricing components (v7.12.0): fix shoelace and allow custom product features #782
Merged
@florian-sanders-cc
Copy link
Contributor Author

Fixed by #782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florian-sanders-cc florian-sanders-cc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@florian-sanders-cc