Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc-pricing-header (7.13.0): default value is not set when using the smart component #791

Closed
florian-sanders-cc opened this issue Jun 23, 2023 · 1 comment
Closed

cc-pricing-header (7.13.0): default value is not set when using the smart component #791

florian-sanders-cc opened this issue Jun 23, 2023 · 1 comment
Assignees
@florian-sanders-cc
Labels
bug Something isn't working

Comments

@florian-sanders-cc
Copy link
Contributor

Context

With the update of the shoelace component (see #782), the default value of the zone select is not set properly when using the smart component (on the website for instance).

This is because the zoneId prop is set by the smart before the zones prop is set. We set the value of the shoelace component before it generates its option.

We've had a similar issue with our own cc-select and we decided to quickfix this using the same logic: rely on the update hook to set the value with native JS everytime zones is updated.
@florian-sanders-cc florian-sanders-cc added the bug Something isn't working label Jun 23, 2023
@florian-sanders-cc florian-sanders-cc self-assigned this Jun 23, 2023
florian-sanders-cc added a commit that referenced this issue Jun 23, 2023
@florian-sanders-cc
fix(cc-pricing-header): force the value of the zone select
efc33af 
Fixes #791
@florian-sanders-cc florian-sanders-cc mentioned this issue Jun 23, 2023
Merged
@florian-sanders-cc
Copy link
Contributor Author

florian-sanders-cc commented Jun 23, 2023 •
edited

Fixed by #790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florian-sanders-cc florian-sanders-cc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@florian-sanders-cc