Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc-header-orga: implement the new state API #884

Closed
florian-sanders-cc opened this issue Nov 15, 2023 · 0 comments · Fixed by #882 or #876
Closed

cc-header-orga: implement the new state API #884

florian-sanders-cc opened this issue Nov 15, 2023 · 0 comments · Fixed by #882 or #876
Assignees
@florian-sanders-cc
Labels
breaking-change Something that will required a major semver release

Comments

@florian-sanders-cc
Copy link
Contributor

florian-sanders-cc commented Nov 15, 2023 •
edited

Context

We're going to adjust the design of cc-header-orga to allow slotted content (see #869).

This component does not implement our new way of handling states to avoid impossible states.
Currently, it still works with nullish values = skeleton and error as a separate boolean.
Even though this component does not have any smart component, the new state API we have implemented (see #708) could work well in this component.

We could first implement the new state API and then do the redesign of the component.
This would make it easier to manipulate the code.
@florian-sanders-cc florian-sanders-cc added the breaking-change Something that will required a major semver release label Nov 15, 2023
@florian-sanders-cc florian-sanders-cc self-assigned this Nov 15, 2023
florian-sanders-cc added a commit that referenced this issue Nov 15, 2023
@florian-sanders-cc
feat(cc-header-orga)!: rework state and types
ff1bc54 
BREAKING CHANGE: check the `HeaderOrgaState` type to adapt your code to the new
state API.

Fixes #884
@florian-sanders-cc florian-sanders-cc mentioned this issue Nov 15, 2023
Merged
florian-sanders-cc added a commit that referenced this issue Nov 28, 2023
@florian-sanders-cc
feat(cc-header-orga)!: rework state and types
8565a20 
BREAKING CHANGE: check the `HeaderOrgaState` type to adapt your code to the new
state API.

Fixes #884
florian-sanders-cc added a commit that referenced this issue Dec 11, 2023
@florian-sanders-cc
feat(cc-header-orga)!: rework state and types
c9540aa 
BREAKING CHANGE: check the `HeaderOrgaState` type to adapt your code to the new
state API.

Fixes #884
florian-sanders-cc added a commit that referenced this issue Dec 11, 2023
@florian-sanders-cc
feat(cc-header-orga)!: rework state and types
727d2f9 
BREAKING CHANGE: check the `HeaderOrgaState` type to adapt your code to the new
state API.

Fixes #884
@pdesoyres-cc pdesoyres-cc mentioned this issue Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florian-sanders-cc florian-sanders-cc

Labels
breaking-change Something that will required a major semver release
Projects
None yet
Milestone
No milestone
1 participant
@florian-sanders-cc