Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl command fails when using npm package #729

Closed
pdesoyres-cc opened this issue Apr 18, 2024 · 1 comment · Fixed by #730 or #731
Closed

curl command fails when using npm package #729

pdesoyres-cc opened this issue Apr 18, 2024 · 1 comment · Fixed by #730 or #731
Assignees
Labels

Comments

@pdesoyres-cc
Copy link
Collaborator

pdesoyres-cc commented Apr 18, 2024

When using clever curl command we got:

node:internal/modules/cjs/loader:1146
  throw err;
  ^

Error: Cannot find module '../../vendors/curlconverter-parse.js'
Require stack:
- /home/kirbeerus/.nvm/versions/node/v20.12.2/lib/node_modules/clever-tools/src/commands/curl.js
- /home/kirbeerus/.nvm/versions/node/v20.12.2/lib/node_modules/clever-tools/bin/clever.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1143:15)
    at Module._load (node:internal/modules/cjs/loader:984:27)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/home/kirbeerus/.nvm/versions/node/v20.12.2/lib/node_modules/clever-tools/src/commands/curl.js:8:20)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
    at Module.load (node:internal/modules/cjs/loader:1206:32)
    at Module._load (node:internal/modules/cjs/loader:1022:12)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/home/kirbeerus/.nvm/versions/node/v20.12.2/lib/node_modules/clever-tools/bin/clever.js:1139:3)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
    at Module.load (node:internal/modules/cjs/loader:1206:32)
    at Module._load (node:internal/modules/cjs/loader:1022:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/kirbeerus/.nvm/versions/node/v20.12.2/lib/node_modules/clever-tools/src/commands/curl.js',
    '/home/kirbeerus/.nvm/versions/node/v20.12.2/lib/node_modules/clever-tools/bin/clever.js'
  ]
}

This error occurs only when using the npm package.

@pdesoyres-cc pdesoyres-cc self-assigned this Apr 18, 2024
pdesoyres-cc added a commit that referenced this issue Apr 18, 2024
@pdesoyres-cc pdesoyres-cc changed the title NPM build is broken clever curl fails when using npm package Apr 18, 2024
@pdesoyres-cc pdesoyres-cc changed the title clever curl fails when using npm package curl command fails when using npm package Apr 18, 2024
@pdesoyres-cc
Copy link
Collaborator Author

The regression was introduced by commit 7197f296, embedded in versions 3.5.2 and 3.6.0.

vendors directory needs to be included into the NPM package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant