Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change <ul> margin #183

Closed
1 task done
davlgd opened this issue Feb 5, 2024 · 5 comments
Closed
1 task done

fix: change <ul> margin #183

davlgd opened this issue Feb 5, 2024 · 5 comments
Assignees
@cnivolle @juliamrch
Labels
bug Something isn't working

Comments

@davlgd
Copy link
Contributor

davlgd commented Feb 5, 2024

Checking for existing issue

  • I have checked for existing issues

Describe the content you'd like to see

If I use a 2-levels list, the <ul> margin leads to render issue. As you can see below, margin-top is too high and there is no margin-bottom:

image

If I replace margin-top: 1.5em by margin-bottom: 1.5em result seems better:

image
@davlgd davlgd added the documentation Improvements or additions to documentation label Feb 5, 2024
@davlgd
Copy link
Contributor Author

davlgd commented Feb 5, 2024

Maybe fixed by Hextra 0.7.2:
https://github.com/imfing/hextra/releases/tag/v0.7.2

fix: set top margin to zero for nested list by @imfing in imfing/hextra#276

@davlgd
Copy link
Contributor Author

davlgd commented Feb 5, 2024

I've quickly checked, it's not enough. I'll open an issue in Hextra repository. I let you decide if you want to make a local fix or wait for a next release on this

@juliamrch juliamrch added bug Something isn't working and removed documentation Improvements or additions to documentation labels Feb 5, 2024
@juliamrch
Copy link
Collaborator

juliamrch commented Feb 5, 2024 •
edited

I've quickly checked, it's not enough. I'll open an issue in Hextra repository. I let you decide if you want to make a local fix or wait for a next release on this

Nice catch. Maybe we could submit a PR on Hextra repo if we fix it before Xin does. @imfing you in?

@imfing imfing mentioned this issue Feb 5, 2024
Closed
@imfing
Copy link

imfing commented Feb 5, 2024

I've quickly checked, it's not enough. I'll open an issue in Hextra repository. I let you decide if you want to make a local fix or wait for a next release on this

Nice catch. Maybe we could submit a PR on Hextra repo if we fix it before Xin does. @imfing you in?

Yes please 🙌

@imfing
Copy link

imfing commented Feb 6, 2024

should be fixed in imfing/hextra#280

davlgd added a commit that referenced this issue Feb 18, 2024
@davlgd
Update Hextra theme to v0.7.3
9414568 
Fixe #183
@davlgd davlgd mentioned this issue Feb 18, 2024
Merged
6 tasks
juliamrch pushed a commit that referenced this issue Feb 19, 2024
@davlgd @juliamrch
Update Hextra theme to v0.7.3
34d6736 
Fixe #183
juliamrch pushed a commit that referenced this issue Feb 21, 2024
@davlgd @juliamrch
Update Hextra theme to v0.7.3
80f7c5b 
Fixe #183
@davlgd davlgd closed this as completed Feb 22, 2024
cnivolle pushed a commit that referenced this issue Feb 27, 2024
@juliamrch @davlgd @florian-sanders-cc
doc: fix guides according to vale linter recommendations (#194)
e333030 
* doc: fic Moodle guide according to vale linter recommendations

* fix passive voice

* doc: update link to WP-Bedrock github tutorial

* changelog: spell fixes (#198)

* changelog: Clever Tools 3.4.0 (#196)

* Simplify PR template

Former template was too detailed and not suited for quick changes like the changelog.

Furthermore, already pre-filled templates seem to reduce author's verbosity. Since there isn't any way of enforcing the filling of a template on PR's like on issues on GitHub, if any additional information is needed it should be requested by the reviewer.

* Update Hextra theme to v0.7.3

Fixe #183

* fix(jenkins): remove pricing information & components

* chore: relocate partials to get proper TOC (iss98)

* chore: relocate partials to get proper TOC (iss98)

* chore: reindex partials to get proper TOC

* chore: replace in codebase every {{< readfile file=file.md >}} used in Laravel tutorial by {{% content/file %}}

* doc: Rewrite Overview and remove 'create-app' partial (not specific enough for Laravel)

* doc-linting: rewrite partials and include new terms in Vale

* doc/laravel: rewrite Laravel guide

- Remove partials: partials are not specific enough for this guide and their style is too vague for specific frameworks.
- Relocate partials: rewriting implied to relocate partials to get proper TOCs in pages, as sepcified in iss98.
- Set guide in steps: use the steps shortcode to clarify the configuration and deployment process

Discussion: Rewriting partials or deprecating their usage for the most part.

* fix link to Bedrock repo

* Update create-application.md

add space before title to try to fix the content rendering

---------

Co-authored-by: David Legrand <1110600+davlgd@users.noreply.github.com>
Co-authored-by: Florian Sanders <florian.sanders@clever-cloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnivolle cnivolle

@juliamrch juliamrch

Labels
bug Something isn't working
Projects
Doc features & improvements
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cnivolle @davlgd @imfing @juliamrch