Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential problem with recent firebase instance id sdk #59

Closed
calvarez-ov opened this issue Mar 12, 2020 · 2 comments
Closed

Potential problem with recent firebase instance id sdk #59

calvarez-ov opened this issue Mar 12, 2020 · 2 comments
Assignees
Labels
enhancement is an enhancement to the SDK pending release Will be released in the next release

Comments

@calvarez-ov
Copy link

calvarez-ov commented Mar 12, 2020

From the firebase instance id release notes:
https://firebase.google.com/support/release-notes/android#iid_v20-1-1

Version 20.1.1 fixes a bug:

Fixed a bug that was causing silent failures in apps that use the deprecated FirebaseInstanceId#getToken() method without providing the required values for FirebaseOptions: API key, Firebase project ID, and application ID. Now, if any required value is missing, it throws an IllegalArgumentException.

Note that we recommend using the FirebaseInstanceId.getInstanceId().getToken() method instead of the deprecated FirebaseInstanceId.getInstance().getToken() method.

I noticed that the clevertap sdk is still using the non-recommended, deprecated FirebaseInstanceId.getInstance().getToken() method, in CleverTapAPI.FCMGetFreshToken()

Please update the sdk to use a more recent version of the firebase dependencies, and to not use deprecated apis.

Apps using the clevertap sdk may be using newer versions of the firebase dependencies, even though cleverap compiles against an old version of messaging, 17.3.0.

@darshanclevertap
Copy link
Collaborator

@calvarez-ov Again, sorry for the late reply, I had this noted. This problem is because we currently do not support the latest FCM version because of AndroidX. All that will change once we move to AndroidX by next month, we will fix this in that release as well. Thank you for your patience with us.

@darshanclevertap darshanclevertap added the enhancement is an enhancement to the SDK label Aug 19, 2020
@darshanclevertap darshanclevertap added the pending release Will be released in the next release label Sep 16, 2020
@darshanclevertap
Copy link
Collaborator

@calvarez-ov Sorry for the extreme delay but we have fixed this in the CleverTap Android SDK v4.0.0. This is a major release as we have started supporting AndroidX and the latest FCM dependency so please check out the changes here which we have made before updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement is an enhancement to the SDK pending release Will be released in the next release
Projects
None yet
Development

No branches or pull requests

3 participants