Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task(SDK-3795) - Fixes NPE #603

Merged
merged 3 commits into from
Jul 8, 2024
Merged

task(SDK-3795) - Fixes NPE #603

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91e2224
task(SDK-3795) - Fixes NPE
Anush-Shand Apr 23, 2024
cb4d98e
task(SDK-3795) - Resolves comments
Anush-Shand Apr 30, 2024
9c1ca65
Merge branch 'feat/bugs/core700qa' into task/SDK-3795/old_inapp_npe
CTLalit Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clevertap-core/src/main/java/com/clevertap/android/sdk/inapp/InAppController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,8 @@ private static void showInApp(Context context, final CTInAppNotification inAppNo
return;
}

boolean isHtmlType = inAppNotification.getType().equals(Constants.KEY_CUSTOM_HTML);
String inAppNotificationType = inAppNotification.getType();
boolean isHtmlType = inAppNotificationType != null && inAppNotificationType.equals(Constants.KEY_CUSTOM_HTML);
if (isHtmlType && !NetworkManager.isNetworkOnline(context)) {
Logger.d(config.getAccountId(),
"Not showing HTML InApp due to no internet. An active internet connection is required to display the HTML InApp");
Expand Down
Loading