Chore: Migrate and check changes #611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- directly migrate exoplayer -> media3 - take a note of changes - app is compilable and running - did not test if features are working fine (in the end we will test) - NOTE: JUST FOR OBSERVATION, DO NOT MERGE
CTLalit
commented
May 23, 2024
| @@ -439,7 +439,7 @@ private static boolean checkForExoPlayer() { | |||
| try { | |||
| className = Class.forName("com.google.android.exoplayer2.ExoPlayer"); | |||
| className = Class.forName("com.google.android.exoplayer2.source.hls.HlsMediaSource"); | |||
| className = Class.forName("com.google.android.exoplayer2.ui.StyledPlayerView"); | |||
| className = Class.forName("com.google.android.exoplayer2.ui.PlayerView"); | |||
There was a problem hiding this comment.
this is incorrect code and we will change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
directly migrate exoplayer -> media3
take a note of changes
app is compilable and running
did not test if features are working fine (in the end we will test)
NOTE: JUST FOR OBSERVATION, DO NOT MERGE