Feature/sdk 3780/exoplayer migration #621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- code cleanup and conditions simplified
- removed exoplay and styledplayerview instance in other handle - the handle provides methods which will be extracted in interface
- removed all exoplayer imports - optimised the code to fold methods - removed recundant checks - rect is reused - stop and release methods called appropriately - todo in activity
- fields made final where possible - optimised the context getting and usage, removed cached field
- the class does not contain any player/surface handling code anymore - deletes the code to ExoplayerHandle.kt class where which we use as a holder to migrate to the media3
- force unwrap avoided
- removed static block and made static field inline.
- removes force unwraps so that there are no NPEs
- is video supported is computed statically by checking class.forname - moved method to correct package
- removed forceful unwraps and used null safe operator.
- did not use static filed from activity.
- removed unref method
- fixes val name clashing
- possible to use field in holder.
- adds media handle which uses media3 components instead of exoplayer - adds a different handle class which has similar func to exo handle - runtime can find the correct handle based on user and attach
- allows use of both impls of media3 as well as exoplayer2 - checks need to be added on runtime to chekc available lib and use appropriate handle
- adds method to check media3 exoplayer which is new lib
- changes to kotlin class from java - force unwraps removed - change method signature which is more optimised for kotlin code
- uses media3 if possible - exoplayer is deprecated but we do not force migration
- changes interface signature so corrected the impl
- uses media3 if available - used exoplayer in other cases
- uses media3 if available - used exoplayer in other cases
Anush-Shand
reviewed
Jun 7, 2024
| ctLockManager, | ||
| callbackManager, | ||
| VideoLibChecker.INSTANCE.haveVideoPlayerSupport | ||
| ) |
There was a problem hiding this comment.
Why not VideoLibChecker.haveVideoPlayerSupport
Anush-Shand
reviewed
Jun 7, 2024
| @Override | ||
| public void onCreate(@Nullable Bundle savedInstanceState) { | ||
| super.onCreate(savedInstanceState); | ||
| if (VideoLibChecker.INSTANCE.mediaLibType == VideoLibraryIntegrated.MEDIA3) { |
There was a problem hiding this comment.
Why not VideoLibChecker.haveVideoPlayerSupport?
Anush-Shand
reviewed
Jun 7, 2024
| public void onCreate(@Nullable Bundle savedInstanceState) { | ||
| super.onCreate(savedInstanceState); | ||
| if (VideoLibChecker.INSTANCE.mediaLibType == VideoLibraryIntegrated.MEDIA3) { | ||
| handle = new Media3Handle(); |
There was a problem hiding this comment.
Can be renamed to videoHandle/ mediaHandle
Anush-Shand
reviewed
Jun 7, 2024
| ); | ||
| } | ||
|
|
||
| private void streamContainer() { |
There was a problem hiding this comment.
Can be renamed to showStreamContainer()?
Anush-Shand
reviewed
Jun 7, 2024
| @@ -74,7 +76,7 @@ private final class NotificationPrepareRunnable implements Runnable { | |||
|
|
|||
| private JSONObject jsonObject; | |||
|
|
|||
| private final boolean videoSupport = Utils.haveVideoPlayerSupport; | |||
| private final boolean videoSupport = VideoLibChecker.INSTANCE.haveVideoPlayerSupport; | |||
There was a problem hiding this comment.
Why not VideoLibChecker.haveVideoPlayerSupport instead of VideoLibChecker.INSTANCE.haveVideoPlayerSupport
Anush-Shand
reviewed
Jun 7, 2024
| @@ -126,4 +126,8 @@ public boolean isVideo() { | |||
| String contentType = this.getContentType(); | |||
| return contentType != null && this.mediaUrl != null && contentType.startsWith("video"); | |||
| } | |||
|
|
|||
| public boolean isStreamMedia() { | |||
There was a problem hiding this comment.
Function names can be made same here and for mediaIsStreamable()
Anush-Shand
reviewed
Jun 7, 2024
| media3ExoplayerPresent = true | ||
| } catch (t: Throwable) { | ||
| Logger.d("Media3 ExoPlayer library files are missing!!!") | ||
| Logger.d("Please add ExoPlayer dependencies to render InApp or Inbox messages playing video. For more information checkout CleverTap documentation.") |
There was a problem hiding this comment.
Logs could be a little misleading
- broken down view method into smaller chunks - makes the fragment readable
- corrects behaviour of add/remove views which are used to steam - optimises add/remove on lifecycle events - optimises view creation for surfaceview and close button - reuses same views in dialog and activity - methods cleanup and renaming
- fixes video view removal/add crash. dialog is reused and video container need not be attached again.
- moves full screen and normal view layout params in handles - sets them correctly as needed
- corrects initialisation after removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exoplayer Migration.