DEV QA fixes SDK-3893 #626
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTLalit
reviewed
Jun 17, 2024
Comment on lines
+60
to
+61
| task.addOnSuccessListener { countDownLatch.countDown() } | ||
| task.addOnFailureListener { countDownLatch.countDown() } |
There was a problem hiding this comment.
thread switching happens when we add success and failure listener, either fix that or you can move it to end of
task.execute("tag") {) block
There was a problem hiding this comment.
fixed in d9ad2fb
…eners on current thread SDK-3893
… before sending to download SDK-3893
…d fails for custom code template SDK-3893
…s unknown for CTInAppType SDK-3893
…for server side in-app assets in prepareForDisplay(), as a result cleanup was also not performed. SDK-3893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilePreloaderExecutors