exiting the process if 0 tests are run in retry run #26
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
| testsToBeRetried += runResult.getFailedTestCases().size(); | ||
| } | ||
|
|
||
| if (testsToBeRetried == 0) { |
There was a problem hiding this comment.
This does not seem correct to me.
If there are no unit tests found, then allTestClasses will be empty. If it is not, then we have at least one unit test. And if we come to this point here, it says that there is no failing test, but in some cases, we don't get a xml file at all. E.g. if the test was running for too long and we had to interrupt the execution. In this case testsToBeRetried will be 0, but we should actually retry.
The problem may be
new TestListResolver(
includes, excludes, getTest(), testClassesDir).scanDirectories()
Check if TestListResolver works fine with non-trivial -Dtest=.... If it works, just check allTestClasses in case mvn exited with non-zero code (i.e. potentially it had zero tests). Though to be even more precise, you may want to check readProcessStdOut for the right error message that there are no tests.
If no unit tests were found in the first run, SuperTest would exit with a status code 0, giving a false success.
This has been resolved now by checking the number of unit tests that are to be run in the retry run.