Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for reinit! #126

Closed
LenkaNovak opened this issue Sep 28, 2022 · 2 comments
Closed

Remove the need for reinit! #126

LenkaNovak opened this issue Sep 28, 2022 · 2 comments
Assignees

Comments

@LenkaNovak
Copy link
Collaborator

LenkaNovak commented Sep 28, 2022

Reinit! reinitializes the initial conditions of the state vector, as well as the integrator object. This is not ideal as it can lead to circular dependencies. The best solution is to call the initial conditions of all models separately, before initialization of any of the models' integrators. With the current ClimaAtmos interface, this is not possible.

This is a medium priority task, potentially requiring substantial interface changes / modularization, so this will be addressed after the mid-October milestone.

Necessary changes

  • split up initialization of the state from the initialization of the integrator, in a way that the coupler can call these in two separate calls.
  • Ensure the same is done for Land (and the other models).

Preferable changes

  • modularize the Atmos driver as a whole
@LenkaNovak
Copy link
Collaborator Author

Just tagging #133 which highlights the need to take another look at reinit! in our time stepping.

@LenkaNovak
Copy link
Collaborator Author

address in #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants