Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative module qualifiers for namespaces #222

Closed
Tracked by #205
valeriabarra opened this issue Jan 11, 2023 · 0 comments · Fixed by #223
Closed
Tracked by #205

Use relative module qualifiers for namespaces #222

valeriabarra opened this issue Jan 11, 2023 · 0 comments · Fixed by #223

Comments

@valeriabarra
Copy link
Member

valeriabarra commented Jan 11, 2023

It is recommended that submodules refer to other modules within the enclosing parent module (including the latter) using relative module qualifiers in using and import statements.

For instance, in src/ConservationChecker.jl, we want to avoid

using ClimaCoupler.Utilities: CoupledSimulation

in favor of:

using ..Utilities: CoupledSimulation

The same pattern applies elsewhere too.

This issue is part of SDI #205

@valeriabarra valeriabarra changed the title Use using ../ to load ClimaCoupler to avoid possible conflicted versions Avoid possible conflicted versions of namespaces Jan 11, 2023
@valeriabarra valeriabarra changed the title Avoid possible conflicted versions of namespaces Use relative module qualifiers for namespaces Jan 12, 2023
@bors bors bot closed this as completed in 18f9c88 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant