Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check water conservation (incl. snow) #404

Closed
9 tasks done
Tracked by #359 ...
LenkaNovak opened this issue Aug 21, 2023 · 0 comments · Fixed by #436
Closed
9 tasks done
Tracked by #359 ...

check water conservation (incl. snow) #404

LenkaNovak opened this issue Aug 21, 2023 · 0 comments · Fixed by #436
Assignees
Labels
🍃 leaf Issue coupled to a PR

Comments

@LenkaNovak
Copy link
Collaborator

LenkaNovak commented Aug 21, 2023

We need to check the water conservation logger (incl. snow), and apply appropriate allowable bounds.

Components

  • fix conservation checker / plotting
    • note that now Atmos uses the kg/m^2/s for evaporation, and m/s for precipitation!
  • add snow - small errors remain - see Fix land snow #421
  • generalize ConservationChecker, to allow for more general tests and extensible development (drop the dependency on underlying models' data structures) Revamp ConservationChecker #436
  • add unit test for water
  • apply allowable bounds to unit tests
  • remove the usage of limiters, which cause worse water conservation, see below (atmos default also doesn't use them)

QA

  • unit tests pass to FP precision
  • no change in performance
  • slabplanet conserves water and energy (though not to FP precision - see above)
Screen Shot 2023-09-26 at 8 15 10 AM Screen Shot 2023-09-26 at 8 15 40 AM

Note, if we apply limiters, water conservation breaks:

Screen Shot 2023-09-26 at 9 47 51 AM
@LenkaNovak LenkaNovak self-assigned this Aug 21, 2023
@LenkaNovak LenkaNovak added the 🍃 leaf Issue coupled to a PR label Aug 21, 2023
@LenkaNovak LenkaNovak changed the title check water conservation (incl. snow, moist test in FluxCalcualtor) check water conservation (incl. snow) Sep 14, 2023
@bors bors bot closed this as completed in #436 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 leaf Issue coupled to a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant