You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
generalize ConservationChecker, to allow for more general tests and extensible development (drop the dependency on underlying models' data structures) Revamp ConservationChecker #436
add unit test for water
apply allowable bounds to unit tests
remove the usage of limiters, which cause worse water conservation, see below (atmos default also doesn't use them)
QA
unit tests pass to FP precision
no change in performance
slabplanet conserves water and energy (though not to FP precision - see above)
Note, if we apply limiters, water conservation breaks:
The text was updated successfully, but these errors were encountered:
We need to check the water conservation logger (incl. snow), and apply appropriate allowable bounds.
Components
QA
Note, if we apply limiters, water conservation breaks:
The text was updated successfully, but these errors were encountered: